Skip to content

Update metaproteomics examples to current SDRF required columns - #1

Open
nithujohn wants to merge 3 commits into
masterfrom
nithujohn-refactored-guide
Open

Update metaproteomics examples to current SDRF required columns#1
nithujohn wants to merge 3 commits into
masterfrom
nithujohn-refactored-guide

Conversation

@nithujohn

Copy link
Copy Markdown
Owner

This PR updates example SDRF files to include required metaproteomics columns from bigbio/sdrf-templates.

Changes:

  • examples/PXD003791/PXD003791.sdrf.tsv: added characteristics[sample name] and characteristics[environmental medium]
  • examples/PXD005969/PXD005969.sdrf.tsv: added characteristics[environmental medium]

Validation (local): ran sdrf-pipelines parse_sdrf validate-sdrf over examples using a local virtualenv (.venv).

  • Command: parse_sdrf validate-sdrf --sdrf_file --template --use_ols_cache_only
  • Result: Structural validation completed; the following example files failed validation and require follow-up fixes:
    • examples/PAD000001/PAD000001.sdrf.tsv
    • examples/PAD000003/PAD000003.sdrf.tsv
    • examples/PXD005969/PXD005969.sdrf.tsv

Notes & next steps:

  • Failures are structural (missing required columns like comment[instrument], comment[proteomics data acquisition method], comment[label] in some files). These appear unrelated to the metaproteomics column additions except PXD005969 which now fails structural checks — recommend reviewing the header ordering/required base columns and restoring any missing base columns.
  • I can (choose): 1) fix the failing SDRF files in this branch, or 2) open the PR as-is and create follow-up issues/PRs for the remaining fixes. Please advise or I can proceed to fix them automatically where safe.

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

nithujohn and others added 3 commits July 29, 2026 12:53
…05969)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…0001, PAD000003, PXD005969)\n\n- Add comment[sdrf template] entries for correct template detection\n- Populate characteristics[sample type] with 'study sample' for affinity proteomics examples\n- Remove empty trailing rows and set project name in PXD005969\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…41 to satisfy ontology validation\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant